Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #6048: Update documentation of recommended models and add deepseek #6050

Merged
merged 9 commits into from
Jan 9, 2025

Conversation

neubig
Copy link
Contributor

@neubig neubig commented Jan 5, 2025

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Update documentation of recommended models and add deepseek to verified providers


Give a summary of what the PR does, explaining any non-trivial design decisions

This adds deepseek to the verified providers and updates documentation with our recent recommendations for models that work OK.

Builds on #6063 to make this build on my computer, 6063 can be reviewed first.


Link of any specific issues this addresses

Fixes #6048


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:ea2228a-nikolaik   --name openhands-app-ea2228a   docker.all-hands.dev/all-hands-ai/openhands:ea2228a

@neubig neubig requested review from mamoodi and enyst January 6, 2025 04:40
@neubig neubig marked this pull request as ready for review January 6, 2025 04:42
@mamoodi
Copy link
Collaborator

mamoodi commented Jan 6, 2025

As a side note, users in Discord are mentioning that even when they select deepseek-coder, it still selects deepseek-chat.

@enyst
Copy link
Collaborator

enyst commented Jan 6, 2025

As a side note, users in Discord are mentioning that even when they select deepseek-coder, it still selects deepseek-chat.

From what I recall, there used to be 2 different models until Deepseek 2.5, then it's only one for 2.5, and now 3.0. In any case, people can choose a different model than those in the drop-down by using Advanced Settings.

I do think that the drop-down should ideally allow you to type over it without resetting what you type, but it seems like a separate issue.

@neubig
Copy link
Contributor Author

neubig commented Jan 7, 2025

Hi @enyst and @mamoodi , sorry, just to clarify, is there anything you'd like me to fix before approving this PR?

Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mamoodi
Copy link
Collaborator

mamoodi commented Jan 7, 2025

No that's alright. The user opened an issue for what I'm talking about. Thanks for checking!

@neubig neubig enabled auto-merge (squash) January 9, 2025 02:33
@neubig neubig merged commit 5458ebb into main Jan 9, 2025
17 checks passed
@neubig neubig deleted the openhands-fix-issue-6048 branch January 9, 2025 02:39
AlexCuadron pushed a commit to AlexCuadron/OpenHands that referenced this pull request Jan 13, 2025
AlexCuadron pushed a commit to AlexCuadron/OpenHands that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation of recommended models and add deepseek
4 participants